[webkit-reviews] review granted: [Bug 22341] Text codecs should not use static data without locking : [Attachment 25244] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 18 12:59:36 PST 2008


Darin Adler <darin at apple.com> has granted Alexey Proskuryakov <ap at webkit.org>'s
request for review:
Bug 22341: Text codecs should not use static data without locking
https://bugs.webkit.org/show_bug.cgi?id=22341

Attachment 25244: proposed patch
https://bugs.webkit.org/attachment.cgi?id=25244&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +    AtomicallyInitializedStatic(Mutex*, mutex = new Mutex);

I should have mentioned this long ago: Macros should use the all-capitals
style. We should rename this one since we're using it more and more. At some
point. Not this patch.

r=me


More information about the webkit-reviews mailing list