[webkit-reviews] review denied: [Bug 22340] Crash at WebCore::AccessibilityTable::isTableExposableThroughAccessibility() when a table changes : [Attachment 25243] patch to stop from crashing

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied chris fleizach <cfleizach at apple.com>'s
request for review:
Bug 22340: Crash at 
WebCore::AccessibilityTable::isTableExposableThroughAccessibility() when a
table changes
https://bugs.webkit.org/show_bug.cgi?id=22340

Attachment 25243: patch to stop from crashing
https://bugs.webkit.org/attachment.cgi?id=25243&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
I don't think this is the right fix.

It makes no sense for AccessibilityTable to call setNeedsSectionRecalc; any
recalculation should be set up by the DOM tree or CSS manipulation that makes
the recalculation necessary.

Similarly, AccessibilityTable should not be responsible for calling
recalcSectionsIfNeeded. Instead the render tree functions used to get at the
sections should take care of that. It does make sense to make a call to update
layout before trying to work with the render tree, but this is not a
table-specific requirement. Layout will call recalcSectionsIfNeeded as
appropriate.

We need to get to the bottom of what's happening here and not just land this,
which is a workaround or band-aid for the real problem.