[webkit-reviews] review requested: [Bug 22299] Improve visual studio 2008 sp1 compilation : [Attachment 25225] Fixes compilation issues with VS2008

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 17 14:04:22 PST 2008


Eric Seidel <eric at webkit.org> has asked  for review:
Bug 22299: Improve visual studio 2008 sp1 compilation
https://bugs.webkit.org/show_bug.cgi?id=22299

Attachment 25225: Fixes compilation issues with VS2008
https://bugs.webkit.org/attachment.cgi?id=25225&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Marc and I talked this out over IM.  The change looks fine.  I'm still slightly
confused as to why the type names need to be different in the forward
declaration.

He pointed out that:
http://msdn.microsoft.com/en-us/library/bb384871.aspx
documents this error.

I would like either Maciej or Darin (Adler) to glance at this before one of us
lands it though.


More information about the webkit-reviews mailing list