[webkit-reviews] review requested: [Bug 18830] Assertion failure (using HashMap empty value) in svg/W3C-SVG-1.1/fonts-glyph-02-t.svg : [Attachment 25224] Fix the calculation...

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 17 13:36:54 PST 2008


Holger Freyther <zecke at selfish.org> has asked  for review:
Bug 18830: Assertion failure (using HashMap empty value) in
svg/W3C-SVG-1.1/fonts-glyph-02-t.svg
https://bugs.webkit.org/show_bug.cgi?id=18830

Attachment 25224: Fix the calculation...
https://bugs.webkit.org/attachment.cgi?id=25224&action=review

------- Additional Comments from Holger Freyther <zecke at selfish.org>
This patch makes the out of bounds string copying go away which is fixing the
assertion failure as well.

I doubt it is the correct fix for RTL. Maybe we need to iterate the other way
around on the string as well? Currently in the first iteration no extra chars
are present/taken into account. But at least I think I have pin pointed the
cause of this crash.


More information about the webkit-reviews mailing list