[webkit-reviews] review granted: [Bug 22308] Improve Worker GC behavior : [Attachment 25211] proposed patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Alexey Proskuryakov <ap at webkit.org>'s
request for review:
Bug 22308: Improve Worker GC behavior
https://bugs.webkit.org/show_bug.cgi?id=22308

Attachment 25211: proposed patch
https://bugs.webkit.org/attachment.cgi?id=25211&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +	   Made hasPendingActivity() virtul, letting Worker add behavior to it.


Misspelled virtual here.

> +   
m_workerContext->thread()->messagingProxy()->reportWorkerThreadActivity(false,
m_workerContext->hasPendingActivity());

The use of booleans makes this a little hard to read. It's not obvious what
that false means. We can use enums to construct named booleans which help make
call sites like this easier to read.

r=me