[webkit-reviews] review granted: [Bug 22312] Fix PCRE include path problem on Qt-port : [Attachment 25216] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 17 09:16:04 PST 2008


Darin Adler <darin at apple.com> has granted Gabor Loki <loki at inf.u-szeged.hu>'s
request for review:
Bug 22312: Fix PCRE include path problem on Qt-port
https://bugs.webkit.org/show_bug.cgi?id=22312

Attachment 25216: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=25216&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> diff --git a/JavaScriptCore/ChangeLog b/JavaScriptCore/ChangeLog
> index 13e79c0..fbc2cea 100644
> --- a/JavaScriptCore/ChangeLog
> +++ b/JavaScriptCore/ChangeLog
> @@ -1,3 +1,13 @@
> +2008-11-17  Gabor Loki  <loki at inf.u-szeged.hu>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	<https://bugs.webkit.org/show_bug.cgi?id=22312>
> +	Fix PCRE include path problem on Qt-port

Please don't put tabs in anything, including ChangeLog entries. This makes
extra work for the committers, who has to change them into spaces.

> +	   * JavaScriptCore.pri:

This file is in the ChangeLog, but not changed in the patch.

r=me


More information about the webkit-reviews mailing list