[webkit-reviews] review granted: [Bug 22056] Share FrameLoaderClient::transitionToCommittedForNewPage between Win/Gtk+/Qt : [Attachment 24870] Share FrameLoaderClient::transitionToCommittedForNewPage between Win/Gtk+/Qt
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Nov 17 07:53:42 PST 2008
Simon Hausmann <hausmann at webkit.org> has granted Holger Freyther
<zecke at selfish.org>'s request for review:
Bug 22056: Share FrameLoaderClient::transitionToCommittedForNewPage between
Win/Gtk+/Qt
https://bugs.webkit.org/show_bug.cgi?id=22056
Attachment 24870: Share FrameLoaderClient::transitionToCommittedForNewPage
between Win/Gtk+/Qt
https://bugs.webkit.org/attachment.cgi?id=24870&action=review
------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
Nice cleanup!
> + FrameView* frameView;
> + if (isMainFrame) {
> + frameView = new FrameView(frame, size);
> + } else
Minor coding style issue with the braces there.
r+ and please fix the braces when landing :)
More information about the webkit-reviews
mailing list