[webkit-reviews] review granted: [Bug 22056] Share FrameLoaderClient::transitionToCommittedForNewPage between Win/Gtk+/Qt : [Attachment 24869] Move recursively setting a background color and toggling transparency to the FrameView

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has granted Holger Freyther
<zecke at selfish.org>'s request for review:
Bug 22056: Share FrameLoaderClient::transitionToCommittedForNewPage between
Win/Gtk+/Qt
https://bugs.webkit.org/show_bug.cgi?id=22056

Attachment 24869: Move recursively setting a background color and toggling
transparency to the FrameView
https://bugs.webkit.org/attachment.cgi?id=24869&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
> +++ b/WebCore/page/FrameView.h
> @@ -101,6 +101,7 @@ public:
>  
>      Color baseBackgroundColor() const;
>      void setBaseBackgroundColor(Color);
> +    void updateBackgroundRecursively(const Color&, bool);

My feeling is that the second argument should have a name. But that's a minor
detail. Otherwise the patch looks good.