[webkit-reviews] review granted: [Bug 21810] Remove use of static C++ objects that are destroyed at exit time (destructors) : [Attachment 25194] JavaScriptCore patch to workaround buggy compilers only when required

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Nov 16 12:47:30 PST 2008


Darin Adler <darin at apple.com> has granted Greg Bolsinga <bolsinga at apple.com>'s
request for review:
Bug 21810: Remove use of static C++ objects that are destroyed at exit time
(destructors)
https://bugs.webkit.org/show_bug.cgi?id=21810

Attachment 25194: JavaScriptCore patch to workaround buggy compilers only when
required
https://bugs.webkit.org/attachment.cgi?id=25194&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +#if COMPILER(GCC) && (__GNUC__ == 4) && (__GNUC_MINOR__ == 0) &&
(__GNUC_PATCHLEVEL__ == 1) && (__APPLE_CC__ == 5465)

This vesrion check seems a little too specific to me. Are you sure that no
other version needs it?

r=me


More information about the webkit-reviews mailing list