[webkit-reviews] review denied: [Bug 21810] Remove use of static C++ objects that are destroyed at exit time (destructors) : [Attachment 25189] WebCore only patch addressing RetainPtr<>, RefPtr<>

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Nov 16 12:45:18 PST 2008


Darin Adler <darin at apple.com> has denied Greg Bolsinga <bolsinga at apple.com>'s
request for review:
Bug 21810: Remove use of static C++ objects that are destroyed at exit time
(destructors)
https://bugs.webkit.org/show_bug.cgi?id=21810

Attachment 25189: WebCore only patch addressing RetainPtr<>, RefPtr<>
https://bugs.webkit.org/attachment.cgi?id=25189&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
As we discussed, lets use DEFINE_STATIC_LOCAL in more places instead of more
efficient hand coded ones.

Also, a couple places where you removed const.


More information about the webkit-reviews mailing list