[webkit-reviews] review granted: [Bug 22295] track which history items are failures, not successes : [Attachment 25197] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Nov 16 11:12:03 PST 2008
mitz at webkit.org has granted Darin Adler <darin at apple.com>'s request for review:
Bug 22295: track which history items are failures, not successes
https://bugs.webkit.org/show_bug.cgi?id=22295
Attachment 25197: patch
https://bugs.webkit.org/attachment.cgi?id=25197&action=review
------- Additional Comments from mitz at webkit.org
> +#include "CachedPage.h"
> +#include "CString.h"
Should headers #includes be sorted alphabetically or in ASCII order? I thought
the latter.
It seems a little dangerous that the presence of the lastVisitWasFailure key in
the dictionary representation always means "true".
r=me
More information about the webkit-reviews
mailing list