[webkit-reviews] review denied: [Bug 20699] SVGPaintServer CleanUp : [Attachment 23627] SVGPaintServer cleanUp - third part

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Nov 15 15:46:05 PST 2008


Dirk Schulze <krit at webkit.org> has denied 's request for review:
Bug 20699: SVGPaintServer CleanUp
https://bugs.webkit.org/show_bug.cgi?id=20699

Attachment 23627: SVGPaintServer cleanUp - third part
https://bugs.webkit.org/attachment.cgi?id=23627&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
This breaks svg/custom/svg-fonts-in-html.html and it gives wrong colors for
svg/W3C-SVG-1.1/painting-fill-05-b.svg.

+	 RGBA32 rgba = color().rgb();
+	 ASSERT(!color().hasAlpha());
+	 if (style)
+	     rgba = colorWithOverrideAlpha(rgba, svgStyle->strokeOpacity());

seems to be handled differently by some platforms.


More information about the webkit-reviews mailing list