[webkit-reviews] review granted: [Bug 22272] The JIT code for calls is HUUUUUUUGE! : [Attachment 25178] The patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 14 16:21:41 PST 2008


Geoffrey Garen <ggaren at apple.com> has granted Gavin Barraclough
<barraclough at apple.com>'s request for review:
Bug 22272: The JIT code for calls is HUUUUUUUGE!
https://bugs.webkit.org/show_bug.cgi?id=22272

Attachment 25178: The patch
https://bugs.webkit.org/attachment.cgi?id=25178&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
emitRetrieveArg

This is a fishy name.

The problem is really that emitGetArg is a bad name. So, we should rename
emitGetArg to emitGetVirtualRegister. Probably a good thing to do after landing
this patch.

r=me


More information about the webkit-reviews mailing list