[webkit-reviews] review granted: [Bug 22260] Two build fixes for WebKit trunk against Symbian S60 : [Attachment 25170] Patch to fix compilation with WINSCW

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 14 09:21:29 PST 2008


Darin Adler <darin at apple.com> has granted Simon Hausmann
<hausmann at webkit.org>'s request for review:
Bug 22260: Two build fixes for WebKit trunk against Symbian S60
https://bugs.webkit.org/show_bug.cgi?id=22260

Attachment 25170: Patch to fix compilation with WINSCW
https://bugs.webkit.org/attachment.cgi?id=25170&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Code change looks OK, but it uses tabs, so we can't check it in as-is.

I'll say r=me, but to save work for committers please don't put patches up for
review if they have tabs. Maybe the Qt folks can configure their git repository
to catch this?


More information about the webkit-reviews mailing list