[webkit-reviews] review granted: [Bug 21991] Add Scons-based build system for Chromium's WebKit build into webkit.org : [Attachment 25153] Add first-stab Chromium-mac WebCore build system

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 13 19:59:22 PST 2008


Adam Roben (aroben) <aroben at apple.com> has granted Eric Seidel
<eric at webkit.org>'s request for review:
Bug 21991: Add Scons-based build system for Chromium's WebKit build into
webkit.org
https://bugs.webkit.org/show_bug.cgi?id=21991

Attachment 25153: Add first-stab Chromium-mac WebCore build system
https://bugs.webkit.org/attachment.cgi?id=25153&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
> +sources['css'] = [
> +'css/CSSBorderImageValue.cpp',
> +'css/CSSCanvasValue.cpp',
> +'css/CSSCharsetRule.cpp',
> +'css/CSSComputedStyleDeclaration.cpp',
> +'css/CSSCursorImageValue.cpp',
> +'css/CSSFontFace.cpp',

Seems like these lines (and many others) should be indented.

r=me


More information about the webkit-reviews mailing list