[webkit-reviews] review denied: [Bug 22240] Add ifdef around toJS function in Plugin.h : [Attachment 25139] patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied John Abd-El-Malek <jam at google.com>'s
request for review:
Bug 22240: Add ifdef around toJS function in Plugin.h
https://bugs.webkit.org/show_bug.cgi?id=22240

Attachment 25139: patch
https://bugs.webkit.org/attachment.cgi?id=25139&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> Index: WebCore/ChangeLog
> ===================================================================
> --- WebCore/ChangeLog (revision 38377)
> +++ WebCore/ChangeLog (working copy)
> @@ -1,3 +1,11 @@
> +2008-11-13  jabdelmalek  <set EMAIL_ADDRESS environment variable>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   WARNING: NO TEST CASES ADDED OR CHANGED
> +
> +	   * plugins/Plugin.h:

This is not a sufficient ChangeLog. You need to put your name in, your email
address, remove the "WARNING" message since this doesn't need test cases, add
the URL of the bug you're fixing, and add a comment explaining the change
you're making.

The code change is great. I'm going to say review- since it should be easy for
you to make a good ChangeLog and re-post the patch with that included.