[webkit-reviews] review requested: [Bug 22177] Need a notification when a form element changes : [Attachment 25136] Patch v2

[bugzilla-daemon at webkit.org]

Brett Wilson (Google) <brettw at chromium.org> has asked Sam Weinig
<sam at webkit.org> for review:
Bug 22177: Need a notification when a form element changes
https://bugs.webkit.org/show_bug.cgi?id=22177

Attachment 25136: Patch v2
https://bugs.webkit.org/attachment.cgi?id=25136&action=review

------- Additional Comments from Brett Wilson (Google) <brettw at chromium.org>
This fixes the style and ChangeLog problems. It adds support for file and
select elements (thanks for noticing this). It adds the similar changes to the
wx, qt, and gtk ports.

I renamed the calleback "formStateChanged" since it's really just form state. I
originally called this page state because that's what we call it, because it
also includes some things such as scroll position that we compute on the port
side. This is irrelevant to this function, however, so the new name is better.

I didn't want to do a DOM hook for form elements for several reasons. It seems
impractical to hook each one individually, and I definitely didn't want to
install a global mutation handler for every page.