[webkit-reviews] review granted: [Bug 22222] selectKeyViewPrecedingView: with document view that can't be first responder makes WebFrameView be first responder : [Attachment 25107] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 12 22:23:16 PST 2008


Mark Rowe (bdash) <mrowe at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 22222: selectKeyViewPrecedingView: with document view that can't be first
responder makes WebFrameView be first responder
https://bugs.webkit.org/show_bug.cgi?id=22222

Attachment 25107: patch
https://bugs.webkit.org/attachment.cgi?id=25107&action=review

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
> +	   // If we couldn't find a previous valid key view, ask the WebView.
This handles frameset
> +	   // cases like. Note that previousValidKeyView should never be self
but can be due to
> +	   // AppKit oddness.

The second sentence of this comment has lost the Radar number.

r=me


More information about the webkit-reviews mailing list