[webkit-reviews] review requested: [Bug 16814] Give plugin a chance to handle ActiveX objects : [Attachment 25111] patch v4

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 12 18:02:34 PST 2008


Peter Kasting <pkasting at google.com> has asked Anders Carlsson
<andersca at apple.com> for review:
Bug 16814: Give plugin a chance to handle ActiveX objects
https://bugs.webkit.org/show_bug.cgi?id=16814

Attachment 25111: patch v4
https://bugs.webkit.org/attachment.cgi?id=25111&action=review

------- Additional Comments from Peter Kasting <pkasting at google.com>
Check supported MIME types after pulling things out of the map instead of
before.  This is shorter and supports the plugin-DB-refreshed-on-the-fly case.

Remove the ENABLEs for everything but wmplayer.  Chromium only needs that one
and no one else needs any of these so why add more than we need to?  It just
clutters the code.


More information about the webkit-reviews mailing list