[webkit-reviews] review requested: [Bug 21810] Remove use of static C++ objects that are destroyed at exit time (destructors) : [Attachment 25102] This patch uses a macro

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 12 13:14:02 PST 2008


Greg Bolsinga <bolsinga at apple.com> has asked  for review:
Bug 21810: Remove use of static C++ objects that are destroyed at exit time
(destructors)
https://bugs.webkit.org/show_bug.cgi?id=21810

Attachment 25102: This patch uses a macro
https://bugs.webkit.org/attachment.cgi?id=25102&action=review

------- Additional Comments from Greg Bolsinga <bolsinga at apple.com>
This is a cleaner patch. It uses a macro for DEFINE_STATIC_LOCAL. This macro
always uses the ugly code right now. It can be updated to check compiler
versions and platform versions to default the the sane static T& = *new T
variant.

I built optimized  on a Leopard system with the 'bad' compiler, and ran all the
LayoutTests without crashing.


More information about the webkit-reviews mailing list