[webkit-reviews] review granted: [Bug 22189] Track CachedScript decoded data : [Attachment 25078] patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org has granted Sam Weinig <sam at webkit.org>'s request for review:
Bug 22189: Track CachedScript decoded data
https://bugs.webkit.org/show_bug.cgi?id=22189

Attachment 25078: patch
https://bugs.webkit.org/attachment.cgi?id=25078&action=review

------- Additional Comments from mitz at webkit.org
> Index: ChangeLog
> ===================================================================
> --- ChangeLog (revision 38320)
> +++ ChangeLog (working copy)
> @@ -1,3 +1,19 @@
> +2008-11-11  Sam Weinig  <sam at webkit.org>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Fix for https://bugs.webkit.org/show_bug.cgi?id=22189
> +	   Track CachedScript decoded data
> +
> +	   * loader/CachedResource.h:
> +	   (WebCore::CachedResource::allClientsRemoved):
> +	   (WebCore::CachedResource::destroyDecodedData):
> +	   * loader/CachedScript.cpp:
> +	   (WebCore::CachedScript::script):
> +	   (WebCore::CachedScript::data):
> +	   (WebCore::CachedScript::destroyDecodedData):
> +	   * loader/CachedScript.h:
> +

You could explain the code changes.

> +    if (m_script.isNull() && m_data) {

You can write this as (!m_script && m_data).

r=me