[webkit-reviews] review requested: [Bug 22131] Ports should be able to provide their own visited link hashing and types : [Attachment 25033] Patch for using 64 bits from a separate file

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 10 16:36:51 PST 2008


Brett Wilson (Google) <brettw at chromium.org> has asked  for review:
Bug 22131: Ports should be able to provide their own visited link hashing and
types
https://bugs.webkit.org/show_bug.cgi?id=22131

Attachment 25033: Patch for using 64 bits from a separate file
https://bugs.webkit.org/attachment.cgi?id=25033&action=review

------- Additional Comments from Brett Wilson (Google) <brettw at chromium.org>
This implements 64-bit hashes and separates them out into another file only. It
doesn't actually use the additional 32 bits since I wasn't sure which hashing
algorithm to use. The easy way out would be to just generate a salt on startup
(I think the hashes are not persisted, right?) and use that as the top 32-bits.


For reference, Chromium uses MD5.

There was some additional discussion in this thread:
https://lists.webkit.org/pipermail/webkit-dev/2008-November/005641.html


More information about the webkit-reviews mailing list