[webkit-reviews] review requested: [Bug 21810] Remove use of static C++ objects that are destroyed at exit time (destructors) : [Attachment 25029] Remove *new construct

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 10 14:57:43 PST 2008


Greg Bolsinga <bolsinga at apple.com> has asked  for review:
Bug 21810: Remove use of static C++ objects that are destroyed at exit time
(destructors)
https://bugs.webkit.org/show_bug.cgi?id=21810

Attachment 25029: Remove *new construct
https://bugs.webkit.org/attachment.cgi?id=25029&action=review

------- Additional Comments from Greg Bolsinga <bolsinga at apple.com>
This is an update to the 11/05/2008 patch.

For each of these: Changed to leak an object to avoid an exit-time destructor.
	
In general code of the form:
	
static T m;
	
became:
	
static T* mPtr = new T;
 T& m = *mPtr;
	
This is to work around <rdar://problem/6354696> Codegen issue with C++ static
reference in gcc build 5465


More information about the webkit-reviews mailing list