[webkit-reviews] review granted: [Bug 14886] Stack overflow due to deeply nested parse tree doing repeated string concatentation : [Attachment 25004] improved patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Nov 9 16:20:35 PST 2008


Sam Weinig <sam at webkit.org> has granted Darin Adler <darin at apple.com>'s request
for review:
Bug 14886: Stack overflow due to deeply nested parse tree doing repeated string
concatentation
https://bugs.webkit.org/show_bug.cgi?id=14886

Attachment 25004: improved patch
https://bugs.webkit.org/attachment.cgi?id=25004&action=edit

------- Additional Comments from Sam Weinig <sam at webkit.org>
Looks good.  My only concern is that "Expression too deep" is a little vague,
but I am short on better alternatives.

r=me


More information about the webkit-reviews mailing list