[webkit-reviews] review granted: [Bug 22134] -[WebHistoryItem dictionaryRepresentation] accesses past the end of a vector : [Attachment 24980] Same patch as before, but with a bit more whitespace and a ChangeLog...

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Nov 9 11:50:56 PST 2008


Darin Adler <darin at apple.com> has granted Aaron Golden <agolden at apple.com>'s
request for review:
Bug 22134: -[WebHistoryItem dictionaryRepresentation] accesses past the end of
a vector
https://bugs.webkit.org/show_bug.cgi?id=22134

Attachment 24980: Same patch as before, but with a bit more whitespace and a
ChangeLog...
https://bugs.webkit.org/attachment.cgi?id=24980&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
This change is clearly correct, but we normally require regression tests for
bug fixes. Were you able to reproduce a problem? I'd love to see a test and not
just the fix.

r=me


More information about the webkit-reviews mailing list