[webkit-reviews] review denied: [Bug 22056] Share FrameLoaderClient::transitionToCommittedForNewPage between Win/Gtk+/Qt : [Attachment 24868] Define the Color::transparent in the cpp file to fix link errors

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Holger Freyther <zecke at selfish.org>'s
request for review:
Bug 22056: Share FrameLoaderClient::transitionToCommittedForNewPage between
Win/Gtk+/Qt
https://bugs.webkit.org/show_bug.cgi?id=22056

Attachment 24868: Define the Color::transparent in the cpp file to fix link
errors
https://bugs.webkit.org/attachment.cgi?id=24868&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
This change isn't right.

We do need to define these in the .cpp file; it was an error to have
definitions in the header only.

But the values should stay in the .h file. This is how C++ static const data
members work. I'll land a corrected version.