[webkit-reviews] review requested: [Bug 21906] [Transforms] Double focus rings on text fields with transforms : [Attachment 24993] Better patch, testcase, changelog
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Nov 8 11:31:32 PST 2008
Simon Fraser <simon.fraser at apple.com> has asked Dave Hyatt <hyatt at apple.com>
for review:
Bug 21906: [Transforms] Double focus rings on text fields with transforms
https://bugs.webkit.org/show_bug.cgi?id=21906
Attachment 24993: Better patch, testcase, changelog
https://bugs.webkit.org/attachment.cgi?id=24993&action=edit
------- Additional Comments from Simon Fraser <simon.fraser at apple.com>
I think this is a much better solution for text controls, as long as the basic
premise is sound:
Override addFocusRingRects() in RenderTextControl to avoid
the RenderFlow behavior of recursing on descendent renderers.
RenderTextControl should only ever need a simple focus rect.
More information about the webkit-reviews
mailing list