[webkit-reviews] review requested: [Bug 21906] [Transforms] Double focus rings on text fields with transforms : [Attachment 24976] Patch, testcase

[bugzilla-daemon at webkit.org]

Simon Fraser <simon.fraser at apple.com> has asked Antti Koivisto
<koivisto at iki.fi> for review:
Bug 21906: [Transforms] Double focus rings on text fields with transforms
https://bugs.webkit.org/show_bug.cgi?id=21906

Attachment 24976: Patch, testcase
https://bugs.webkit.org/attachment.cgi?id=24976&action=edit

------- Additional Comments from Simon Fraser <simon.fraser at apple.com>
This is a nasty fix and I don't like it, but I can't think of another way.

The problem is that RenderFlow::addFocusRingRects() is computing an absolute
rect for the focus ring of a child, but there's a transform in the parent chain
(so the CTM has been changed). The only way to really fix this is to have each
child of the RenderFlow draw its own part of the focus ring (since one of those
children may be transformed). Amassing a set of focus rects as the code does
not is never going to work correctly in all cases.

However, this patch fixes the simple case of a transformed <input> or
<textarea>