[webkit-reviews] review granted: [Bug 22112] if a <body> has contenteditable=true, it should report a writable AXValue : [Attachment 24954] patch to make web areas have writable AXValue if contenteditable exists

Thu Nov 6 13:58:34 PST 2008

Beth Dakin <bdakin at apple.com> has granted chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 22112: if a <body> has contenteditable=true, it should report a writable
AXValue
https://bugs.webkit.org/show_bug.cgi?id=22112

Attachment 24954: patch to make web areas have writable AXValue if
contenteditable exists
https://bugs.webkit.org/attachment.cgi?id=24954&action=edit

------- Additional Comments from Beth Dakin <bdakin at apple.com>
> Index: WebCore/page/AccessibilityRenderObject.cpp
> ===================================================================
> --- WebCore/page/AccessibilityRenderObject.cpp	(revision 38190)
> +++ WebCore/page/AccessibilityRenderObject.cpp	(working copy)
> @@ -341,6 +341,10 @@ bool AccessibilityRenderObject::isReadOn
>	   if (!document)
>	       return true;
>	   
> +	   HTMLElement *body = document->body();
> +	   if (body && body->isContentEditable())
> +	       return false;
> +	   
>	   Frame* frame = document->frame();
>	   if (!frame)
>	       return true;

You should move the star -- should be: HTMLElement* body =…

> Index: WebKitTools/DumpRenderTree/AccessibilityUIElement.h
> ===================================================================
> --- WebKitTools/DumpRenderTree/AccessibilityUIElement.h	(revision
38190)
> +++ WebKitTools/DumpRenderTree/AccessibilityUIElement.h	(working copy)
> @@ -69,8 +69,10 @@ public:
>      JSStringRef attributesOfDocumentLinks();
>      JSStringRef attributesOfChildren();
>      JSStringRef parameterizedAttributeNames();
> -    
> +	  

You should fix this whitespace change.

r=me