[webkit-reviews] review requested: [Bug 21635] Use UTF-8 for Unicode encodings other than UTF-8 when submitting a form or encoding the query part of a URL : [Attachment 24910] upated patch

[bugzilla-daemon at webkit.org]

Jungshik Shin <jshin at chromium.org> has asked Darin Adler <darin at apple.com> for
review:
Bug 21635: Use UTF-8 for Unicode encodings other than UTF-8 when submitting a
form or encoding the query part of a URL
https://bugs.webkit.org/show_bug.cgi?id=21635

Attachment 24910: upated patch
https://bugs.webkit.org/attachment.cgi?id=24910&action=edit

------- Additional Comments from Jungshik Shin <jshin at chromium.org>
Darin, can you take another look?  
I used 'NonByteBased' for both functions because 'Non8Bit' can mean both '7bit
encodings' like ISO-2022-JP and GB-HZ and non-byte-based encodings like
UTF-16/32.  
Also, I just used 'file static' instead of anonymous namespace to follow the
webkit convention. 
I updated comments and try to be as clear as possible (but I'm afraid I'm not
so successful).