[webkit-reviews] review denied: [Bug 22071] [Qt] Unable to retrieve meta data from a frame : [Attachment 24901] Patch to add meta data API to QWebFrame

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has denied Sriram
<sriram.yadavalli at nokia.com>'s request for review:
Bug 22071: [Qt] Unable to retrieve meta data from a frame
https://bugs.webkit.org/show_bug.cgi?id=22071

Attachment 24901: Patch to add meta data API to QWebFrame
https://bugs.webkit.org/attachment.cgi?id=24901&action=edit

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
> Index: qwebframe.cpp
> ===================================================================
> --- qwebframe.cpp	(revision 38051)
> +++ qwebframe.cpp	(working copy)
> @@ -8,7 +8,7 @@
>      version 2 of the License, or (at your option) any later version.
>  
>      This library is distributed in the hope that it will be useful,
> -    but WITHOUT ANY WARRANTY; without even the implied warranty of
> +    but WITHOUT ANY WARRANTY; without paeven the implied warranty of

This looks like an unintended typo :)

>      MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
>      Library General Public License for more details.
>  
> @@ -70,6 +70,7 @@
>  #include <qevent.h>
>  #include <qfileinfo.h>
>  #include <qpainter.h>
> +#include <QMultiMap>
>  #if QT_VERSION >= 0x040400
>  #include <qnetworkrequest.h>
>  #else
> @@ -77,6 +78,8 @@
>  #endif
>  #include <qregion.h>
>  #include <qprinter.h>
> +#include "HTMLMetaElement.h"
> +#include "NodeList.h"
>  
>  using namespace WebCore;
>  
> @@ -280,6 +283,26 @@
>      else return QString();
>  }
>  
> +/*!

Can you add a \since 4.5 here? thanks :) (sorry, small nitpick)

> +    \brief Returns the meta data in this frame
> +    \sa metaData()
> +*/

The patch looks great. It's just missing a ChangeLog entry. And perhaps you
could write a little bit more in the docs of the function. But this is really
just a nitpick, I could add that while committing. The ChangeLog entry is
missing though. I think Yael could help with that, too :)

I'll r- for now, but with a ChangeLog entry and the typo in the copyright I'll
r+ it :)




In pri