[webkit-reviews] review cancelled: [Bug 15643] Double-clicking word should select whitespace after the word : [Attachment 24822] Possible patch to issue 15643

[bugzilla-daemon at webkit.org]

Glenn Wilson <gwilson at google.com> has cancelled Glenn Wilson
<gwilson at google.com>'s request for review:
Bug 15643: Double-clicking word should select whitespace after the word
https://bugs.webkit.org/show_bug.cgi?id=15643

Attachment 24822: Possible patch to issue 15643
https://bugs.webkit.org/attachment.cgi?id=24822&action=edit

------- Additional Comments from Glenn Wilson <gwilson at google.com>
>Placing it to Editor.h seems good to me. I think that just the first two lines

>of the comment may be enough, but you may try asking someone who doesn't have
>the knowledge about smart select in cache memory :)

I took out all but the first two lines.  The bug number is in the changelogs,
so I guess anyone really curious about the logic can check here :)

>Yes, I think that this new name is confusing, either the original "include" or

>"append" would be better.

I agree...changed to "appendTrailingWhitespace", which makes it very clear what
the method is doing.

>Yes, this should be private, as no one expressed the desire to make it a
public
>Mac OS X API eventually.

Ok, moved this out of WebPendingPublic to WebPrivate.

Since Adam mentioned that moving the new method signatures to the end of the
interface in the IDL is the right approach, the IDL change shouldn't break the
nightly builds.

Thanks for all of the great feedback!  Let me know if I missed anything...