[webkit-reviews] review granted: [Bug 22054] DRT does not properly reset scrollbar arrows to default : [Attachment 24874] Tentative patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 3 18:08:40 PST 2008


mitz at webkit.org has granted Pierre-Olivier Latour <pol at apple.com>'s request for
review:
Bug 22054: DRT does not properly reset scrollbar arrows to default
https://bugs.webkit.org/show_bug.cgi?id=22054

Attachment 24874: Tentative patch
https://bugs.webkit.org/attachment.cgi?id=24874&action=edit

------- Additional Comments from mitz at webkit.org
> +    CFTypeRef oldValue =
CFPreferencesCopyValue(CFSTR("AppleScrollBarVariant"),
kCFPreferencesAnyApplication, kCFPreferencesCurrentUser,
kCFPreferencesAnyHost);

You can use a RetainPtr for that and create create a local variable to hold
CFSTR("AppleScrollBarVariant"). It would also be nice to move this closer to
where you set the default in NSUserDefaults.

r=me


More information about the webkit-reviews mailing list