[webkit-reviews] review granted: [Bug 19180] speed up SunSpider by optimizing immediate number cases : [Attachment 21430] Patch for << and >>>

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Alexey Proskuryakov <ap at webkit.org>'s
request for review:
Bug 19180: speed up SunSpider by optimizing immediate number cases
http://bugs.webkit.org/show_bug.cgi?id=19180

Attachment 21430: Patch for << and >>>
http://bugs.webkit.org/attachment.cgi?id=21430&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
If you fixed a regression on PowerPC, was there a regression test indicating
it?

+	 (KJS::JSImmediate::toTruncatedUInt32): Added. Same as
getTruncatedInt32, but casts the result
+	 to unsigned.

I'm concerned about the "to" vs. "get" in the name here. This class seems we
use "get" to mean "convert with no possibility of error" and "to" to mean
"convert with a possible exception or error".

r=me