[webkit-reviews] review requested: [Bug 19273] BitmapImage.cpp erroneously assumes repetition count is available once size is available : [Attachment 21404] patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 28 15:12:45 PDT 2008


Peter Kasting <zerodpx at gmail.com> has asked  for review:
Bug 19273: BitmapImage.cpp erroneously assumes repetition count is available
once size is available
http://bugs.webkit.org/show_bug.cgi?id=19273

Attachment 21404: patch v1
http://bugs.webkit.org/attachment.cgi?id=21404&action=edit

------- Additional Comments from Peter Kasting <zerodpx at gmail.com>
Here's a patch to fix.	I didn't realize that the GIFImageDecoder deletes
m_reader as soon as the GIF finishes decoding, so I had to add a member to
GIFImageDecoder to hold the repetition count after that point.	(I didn't
bother to plumb a notification from the reader up to the decoder that the count
has changed, since BitmapImage.cpp will only ask for this data either very
early or after the whole image has decoded, so this wouldn't have bought us
anything.)


More information about the webkit-reviews mailing list