[webkit-reviews] review denied: [Bug 15823] getPropertyValue for border returns null, should compute the shorthand value : [Attachment 20947] First attempt

[bugzilla-daemon at webkit.org]

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has denied Rob Buis
<rwlbuis at gmail.com>'s request for review:
Bug 15823: getPropertyValue for border returns null, should compute the
shorthand value
http://bugs.webkit.org/show_bug.cgi?id=15823

Attachment 20947: First attempt
http://bugs.webkit.org/attachment.cgi?id=20947&action=edit

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
What happens when you try to get the "border" property of a div like this?

  <div id="border" style="border-left: 5px solid red; border-top: 5px solid
green; border-right: 5px solid blue; border-bottom: 5px solid purple; " ></div>


I think it returns "5px 5px 5px 5px solid solid solid solid green blue purple
red", which is not a legal value for the "border" property.

Does the CSS spec say what should happen in the case where a single "border"
property can't accurately represent an element's border?

I tried the above test case in Firefox 2.0.0.x, and it returns the value for
"border-top" when asking for the "border" property!  Not sure what MSIE 6 or 7
do.

r- since this change doesn't return a value valid in the negative case.  (We
should at least have a "negative" test case as well.)