[webkit-reviews] review denied: [Bug 18887] WF2 Support for autofocus controls : [Attachment 21310] Initial implementation, third revision

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 27 13:59:12 PDT 2008

Adele Peterson <adele at apple.com> has denied Michelangelo De Simone
<m.des at mac.com>'s request for review:
Bug 18887: WF2 Support for autofocus controls

Attachment 21310: Initial implementation, third revision

------- Additional Comments from Adele Peterson <adele at apple.com>
Great work so far-- you're almost there!  A few comments...

1)The test you added is a good basic test, but it only tests that the attribute
is right.  Not that the focus behavior is right.  It would be nice to add
versions of those Opera tests too for a more thorough test suite.  It would
also be good to have at least one test for "ignoreAutofocus", if that's

2) The ChangeLog should have detailed entries for each change.

3) In HTMLGenericFormElement::attach, you shouldn't need to check for disabled
since that is already checked in focus() by calling supportsFocus() and
isFocusable().	In fact...should isFocusable() include a check for read-only?

More information about the webkit-reviews mailing list