[webkit-reviews] review denied: [Bug 19242] Data URLs should set an Access-Control-Origin of "null" : [Attachment 21332] untested patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 26 14:33:38 PDT 2008

Sam Weinig <sam at webkit.org> has denied Adam Barth <abarth at webkit.org>'s request
for review:
Bug 19242: Data URLs should set an Access-Control-Origin of "null"

Attachment 21332: untested patch

------- Additional Comments from Sam Weinig <sam at webkit.org>
I think the logic for:
     String accessControlOrigin = m_doc->securityOrigin()->toString();
+    if (accessControlOrigin.isEmpty())
+	 accessControlOrigin = "null";
should be lifted out into a separate function.	There is one other places that
put the access-control-origin into the request that you have missed, in
handleAsynchronousMethodCheckResult where the helper should be used.

More information about the webkit-reviews mailing list