[webkit-reviews] review granted: [Bug 16489] WebKit does not support ElementTraversal specification : [Attachment 21338] New fixed patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Vincent Ricard
<magic at magicninja.org>'s request for review:
Bug 16489: WebKit does not support ElementTraversal specification
http://bugs.webkit.org/show_bug.cgi?id=16489

Attachment 21338: New fixed patch
http://bugs.webkit.org/attachment.cgi?id=21338&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Are these functions supposed to be defined on Document objects, or just Element
objects?

+    Node* n = this->firstChild();
+    Node* n = this->lastChild();
+    Node* n = this->previousSibling();
+    Node* n = this->nextSibling();
+    Node* n = this->firstChild();

No need for the explicit "this->" here.

+	 * fast/js/ElementTraversal-childElementCount.html: Added.
+	 * fast/js/ElementTraversal-firstElementChild.html: Added.
+	 * fast/js/ElementTraversal-lastElementChild.html: Added.
+	 * fast/js/ElementTraversal-nextElementSibling.html: Added.
+	 * fast/js/ElementTraversal-previousElementSibling.html: Added.
+	 * fast/js/resources/ElementTraversal-childElementCount.js: Added.
+	 * fast/js/resources/ElementTraversal-firstElementChild.js: Added.
+	 * fast/js/resources/ElementTraversal-lastElementChild.js: Added.
+	 * fast/js/resources/ElementTraversal-nextElementSibling.js: Added.
+	 * fast/js/resources/ElementTraversal-previousElementSibling.js: Added.


This is no longer the accurate list of files added.

r=me, but it would be better to fix the above issues