[webkit-reviews] review granted: [Bug 18512] getPresentationAttribute returns a shared object : [Attachment 20696] Now with testcase

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat May 24 23:22:03 PDT 2008


Darin Adler <darin at apple.com> has granted Rob Buis <rwlbuis at gmail.com>'s
request for review:
Bug 18512: getPresentationAttribute returns a shared object
http://bugs.webkit.org/show_bug.cgi?id=18512

Attachment 20696: Now with testcase
http://bugs.webkit.org/attachment.cgi?id=20696&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
+    if (cssSVGAttr->style()->refCount() > 1) {

The hasOneRef() function was made for uses like this one. I think it'd be
better to use that.

r=me


More information about the webkit-reviews mailing list