[webkit-reviews] review denied: [Bug 18041] DOMNodeRemoved events are sent twice : [Attachment 21174] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat May 24 22:47:21 PDT 2008

Darin Adler <darin at apple.com> has denied Vincent Ricard
<magic at magicninja.org>'s request for review:
Bug 18041: DOMNodeRemoved events are sent twice

Attachment 21174: Patch

------- Additional Comments from Darin Adler <darin at apple.com>
Code change looks perfect. Oops!

The patch needs to include the results of the regression test. That's the
DOMNodeRemovedEvent -expected.txt file.

The regression test should be turned into a text-only test so it doesn't dump
the layout of the elements. That can be done by adding this code:

    if (window.layoutTestController)

to the test. By doing this, you'll make the test work as-is cross-platform and
also eliminate the need to check in "pixel test results".

Please resubmit the patch with a corrected regression test, and we'll get this
checked in.

More information about the webkit-reviews mailing list