[webkit-reviews] review denied: [Bug 16881] [GTK] PlatformScreenGtk is unimplemented : [Attachment 21296] Implement stubs

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 23 07:46:42 PDT 2008

Alp Toker <alp at nuanti.com> has denied Marco Barisione
<marco.barisione at collabora.co.uk>'s request for review:
Bug 16881: [GTK] PlatformScreenGtk is unimplemented

Attachment 21296: Implement stubs

------- Additional Comments from Alp Toker <alp at nuanti.com>
This will break non-X11 builds. Please wrap with an #if defined(...) and
provide a fallback using standard GTK+ API.

You should also try to ensure that this code won't crash when no windowing
system is active as we do elsewhere. This is so we can support commandline
tools like web thumbnailers in future.

More information about the webkit-reviews mailing list