[webkit-reviews] review granted: [Bug 18451] REGRESSION: Resource Request and Response headers aren't shown : [Attachment 21280] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 21 20:12:38 PDT 2008


Adam Roben (aroben) <aroben at apple.com> has granted Timothy Hatcher
<timothy at hatcher.name>'s request for review:
Bug 18451: REGRESSION: Resource Request and Response headers aren't shown
http://bugs.webkit.org/show_bug.cgi?id=18451

Attachment 21280: Proposed patch
http://bugs.webkit.org/attachment.cgi?id=21280&action=edit

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
+	 (WebInspector.SourceFrame.prototype.get autoSizeToFitContentHeight):
+	 (WebInspector.SourceFrame.prototype.set autoSizeToFitContentHeight):
+	 (WebInspector.SourceFrame.prototype.sizeToFitContentHeight):

I think the getter/setter should be prefixed with "should", or you could say
"autoSizes" instead of "autoSize". That way this property won't be a verb
phrase.

r=me


More information about the webkit-reviews mailing list