[webkit-reviews] review denied: [Bug 16489] WebKit does not support ElementTraversal specification : [Attachment 21260] Patch + testcases

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 20 14:34:38 PDT 2008

Eric Seidel <eric at webkit.org> has denied Vincent Ricard
<magic at magicninja.org>'s request for review:
Bug 16489: WebKit does not support ElementTraversal specification

Attachment 21260: Patch + testcases

------- Additional Comments from Eric Seidel <eric at webkit.org>
The implementation looks fine.

The test cases should be written as js test cases, following the form used by
so many in fast/js (and other places).	you can use make-js-test-wrappers to
generate the final .html files once you add your .js files.  (js test cases use
our shouldBe functions, etc.)

Also, these new functions on Element should be const.

Otherwise it looks fine to me.

I would r+ this but, AFAIK you don't have commit bit (so any edits you make
need to go through a posted patch).  So I'd like to see a patch with cleaner
test cases before r+ing.


More information about the webkit-reviews mailing list