[webkit-reviews] review granted: [Bug 12053] SVGPathSeg*(Abs|Rel) classses should be combined to reduce code size : [Attachment 21221] First attempt

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Rob Buis <rwlbuis at gmail.com>'s
request for review:
Bug 12053: SVGPathSeg*(Abs|Rel) classses should be combined to reduce code size
http://bugs.webkit.org/show_bug.cgi?id=12053

Attachment 21221: First attempt
http://bugs.webkit.org/attachment.cgi?id=21221&action=edit

------- Additional Comments from Eric Seidel <eric at webkit.org>
+	 virtual String toString() const { return pathSegTypeAsLetter() +
String::format(" %.6lg %.6lg", m_x, m_y); }

Might be more efficient if you passed the char as part of the format.  Not sure
it matters though.

Generally we encourage each of these to get their own line:
 36	    : m_x(x), m_y(y), m_r1(r1), m_r2(r2), m_angle(angle),
m_largeArcFlag(largeArcFlag), m_sweepFlag(sweepFlag) {}


In general looks great!  I love all the minus lines.