[webkit-reviews] review denied: [Bug 19077] [Qt] Clicking on a link with target=_blank doesn't do anything : [Attachment 21163] Show the window containing the newly created QWebPage

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has denied Marco Barisione
<marco.barisione at collabora.co.uk>'s request for review:
Bug 19077: [Qt] Clicking on a link with target=_blank doesn't do anything
http://bugs.webkit.org/show_bug.cgi?id=19077

Attachment 21163: Show the window containing the newly created QWebPage
http://bugs.webkit.org/attachment.cgi?id=21163&action=edit

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
I don't think this is the right place to call show(). dispatchCreatePage() is
called from FrameLoader::continueAfterNewWindowPolicy, which shortly afterwards
calls FrameLoaderClient::dispatchShow(). That function is currently not
implemented and I believe that's where a show() call should go.