[webkit-reviews] review granted: [Bug 18991] SquirrelFish: Major codegen issue in a.b=expr, a[b]=expr : [Attachment 21212] Revised proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat May 17 03:26:17 PDT 2008


Oliver Hunt <oliver at apple.com> has granted 's request for review:
Bug 18991: SquirrelFish: Major codegen issue in a.b=expr, a[b]=expr
http://bugs.webkit.org/show_bug.cgi?id=18991

Attachment 21212: Revised proposed patch
http://bugs.webkit.org/attachment.cgi?id=21212&action=edit

------- Additional Comments from Oliver Hunt <oliver at apple.com>
The PassRefPtr stuff isn't the nicest thing i've ever seen, but i can't think
of anything nicer.

This needs a testcase, and we should probably file individual bugs for the
function.arguments, f(f=3), and for..in issues.


More information about the webkit-reviews mailing list