[webkit-reviews] review requested: [Bug 17433] getComputedStyle() -> clip returns empty string : [Attachment 21195] First attempt

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has asked	for review:
Bug 17433: getComputedStyle() ->  clip	returns empty string
http://bugs.webkit.org/show_bug.cgi?id=17433

Attachment 21195: First attempt
http://bugs.webkit.org/attachment.cgi?id=21195&action=edit

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
So now we give a better CSSPrimitiveValue for the computed value of 'clip'.
What is not completely clear to me is how to treat 'auto'. Right now it returns

rect(0px, 0px, 0px, 0px), I would have expected something with at least a width

and height, also no clipping can be seen. However if I specify rect(0px, 0px,
0px, 0px) explicitly, there is clipping. I don't see how a distinction is made
between these two cases, and whether it is relevant for the computed value.
Opera also returns what we return for auto, FF3 just returns 'auto'.
Cheers,

Rob.