[webkit-reviews] review requested: [Bug 19085] font-family: initial sets font-family differently than font: initial : [Attachment 21175] Patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 15 13:23:52 PDT 2008


David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked  for review:
Bug 19085: font-family: initial sets font-family differently than font: initial
http://bugs.webkit.org/show_bug.cgi?id=19085

Attachment 21175: Patch v1
http://bugs.webkit.org/attachment.cgi?id=21175&action=edit

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
Proposed patch and test case.

Instead of checking !initialDesc.firstFamily().familyIsEmpty() (which is always
true for a new FontDescription()), the line that sets the family could just be
removed.  I figured this was slightly safer in case the FontDescription default
constructor changed in the future.


More information about the webkit-reviews mailing list