[webkit-reviews] review granted: [Bug 19076] SquirrelFish: RegisterFile can be corrupted if implictly reenter global scope with no declared vars : [Attachment 21161] a fix

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Oliver Hunt <oliver at apple.com>'s
request for review:
Bug 19076: SquirrelFish: RegisterFile can be corrupted if implictly reenter
global scope with no declared vars
http://bugs.webkit.org/show_bug.cgi?id=19076

Attachment 21161: a fix
http://bugs.webkit.org/attachment.cgi?id=21161&action=edit

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
It's a little squirrely to have a variable named "m_thisRegister" that's only
valid if we happen to be compiling program code.

I'd recommend setting m_thisRegister when compiling function code and eval code
as well. Then, "thisRegister()" can always return m_thisRegister, which makes a
lot more sense.

Eventually, we'll won't put "this" in the symbol table at all.

r=me